-
Notifications
You must be signed in to change notification settings - Fork 6.5k
ppai: fix lint errors #7788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ppai: fix lint errors #7788
Conversation
|
Ah crap - this might be a backwards compatibility thing. If that's the case and we need to maintain compatibility with older versions of Python and that means we have to use Any, that's an okay justification. |
Few more issues:
Is the 404 error flaky? Or is it an actual error? |
…ples into ppai-lint-errors
It looks like the Dataflow pipeline failed with |
It looks like there's some sort of exception on saving the global context for the Beam library itself. It looks like it's something that changed on a more recent version because it wasn't an issue before. Importing beam explicitly inside those functions seems to fix it. |
It's not finding the AutoML model to do predictions. The model was a permanent resource and it somehow got deleted. I'm going to make a fallback so if it doesn't find the model in AutoML, it'll use a mock implementation to simply test that all methods are called correctly. |
…ples into ppai-lint-errors
Description
Fixes #7786
Checklist
nox -s py-3.6
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)