Skip to content

fix: add GCE enforce exception for compute flaky test #9175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 6, 2023
Merged

fix: add GCE enforce exception for compute flaky test #9175

merged 7 commits into from
Mar 6, 2023

Conversation

kweinmeister
Copy link
Contributor

Fixes #9113

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: compute Issues related to the Compute Engine API. labels Feb 26, 2023
@kweinmeister kweinmeister added the snippet-bot:force-run Force snippet-bot runs its logic label Feb 26, 2023
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Feb 26, 2023
@kweinmeister kweinmeister marked this pull request as ready for review February 26, 2023 22:45
@kweinmeister kweinmeister requested review from m-strzelczyk and a team as code owners February 26, 2023 22:45
@m-strzelczyk
Copy link
Contributor

The failure in 3.11 is not related to this change. I will admin merge this PR for now.

@m-strzelczyk m-strzelczyk added the automerge Merge the pull request once unit tests and other checks pass. label Mar 6, 2023
@m-strzelczyk m-strzelczyk merged commit 09dcac5 into main Mar 6, 2023
@m-strzelczyk m-strzelczyk deleted the issue-9113 branch March 6, 2023 15:15
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 6, 2023
telpirion pushed a commit that referenced this pull request Mar 13, 2023
@kweinmeister @m-strzelczyk
@rsamborski @telpirion
fix: add GCE enforce exception for compute flaky test (#9175)
0767ca7 
Co-authored-by: Maciej Strzelczyk <strzelczyk@google.com>
Co-authored-by: Remigiusz Samborski <rsamborski@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsamborski rsamborski rsamborski approved these changes

@m-strzelczyk m-strzelczyk m-strzelczyk approved these changes

Assignees
No one assigned
Labels
api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compute.client_library.snippets.tests.test_firewall: test_patch_rule failed
3 participants
@kweinmeister @m-strzelczyk @rsamborski