Skip to content

fix: add GCE enforce exception for compute flaky test #9175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 6, 2023
Merged

fix: add GCE enforce exception for compute flaky test #9175

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fa4abf4
fix: add GCE enforce exception for compute flaky test
kweinmeister Feb 26, 2023
013565c
Merge branch 'main' into issue-9113
kweinmeister Feb 27, 2023
566639a
Merge branch 'main' into issue-9113
kweinmeister Feb 27, 2023
9e41be1
Merge branch 'main' into issue-9113
m-strzelczyk Feb 28, 2023
f3dc8f2
Merge branch 'main' into issue-9113
rsamborski Feb 28, 2023
8dd037b
Merge branch 'main' into issue-9113
kweinmeister Mar 2, 2023
c2c3383
Merge branch 'main' into issue-9113
m-strzelczyk Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion compute/client_library/snippets/tests/test_firewall.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,15 @@ def test_create(autodelete_firewall_name):
def test_patch_rule(firewall_rule):
fw_client = compute_v1.FirewallsClient()
assert firewall_rule.priority == 1000
patch_firewall_priority(PROJECT, firewall_rule.name, 500)
try:
patch_firewall_priority(PROJECT, firewall_rule.name, 500)
except google.api_core.exceptions.BadRequest as err:
if err.code == 400 and "is not ready" in err.message:
# We can ignore this, this is most likely GCE Enforcer removing the rule before us.
return
else:
# Something else went wrong, let's escalate it.
raise err
time.sleep(2)
updated_firewall_rule = fw_client.get(project=PROJECT, firewall=firewall_rule.name)
assert updated_firewall_rule.priority == 500