Skip to content
This repository was archived by the owner on Feb 15, 2023. It is now read-only.

WIP, MAINT: try 3.10rc wheels #124

Closed
wants to merge 1 commit into from
Closed

WIP, MAINT: try 3.10rc wheels #124

wants to merge 1 commit into from

Conversation

tylerjereddy
Copy link
Collaborator

I'm guessing it is not going to be as easy as just copying what @mattip and @charris did but isn't going to stop me from trying :) Some of our SciPy wheels infra/base images normally used are a bit older perhaps too?

I think even if we do succeed I'd be hesitant to actually put the rc wheel on PyPI vs. just making it available on the anaconda testbed.

@tylerjereddy
Copy link
Collaborator Author

oh, is config_ilp64.sh a NumPy specific thing? I may need to dig a little

@tylerjereddy tylerjereddy mentioned this pull request Aug 13, 2021
Closed
@charris
Copy link
Contributor

charris commented Aug 13, 2021

Yep, config_ilp64.sh was needed to build 64 bit blas wheels. If you stick with 32 bit blas integers you won't need it.

@tylerjereddy tylerjereddy force-pushed the treddy_try_python_310 branch from 4310e94 to 0a07e27 Compare August 13, 2021 03:37
@tylerjereddy
Copy link
Collaborator Author

After removing that, numpy.distutils.system_info.NotFoundError: No BLAS/LAPACK libraries found.

@tylerjereddy
Copy link
Collaborator Author

We are way behind NumPy in terms of the OpenBLAS version we are shipping with wheels, not sure if related.

@mattip
Copy link
Contributor

mattip commented Aug 13, 2021

We are way behind NumPy in terms of the OpenBLAS version

You might want to sync tools/openblas_support.py with the one in NumPy

@mattip
Copy link
Contributor

mattip commented Aug 13, 2021

Maybe connected to downloading a manylinux1 openblas which later on cannot be linked since it is missing some gfortran symbols

@mattip
Copy link
Contributor

mattip commented Aug 13, 2021

xref scipy/scipy#14316

@tylerjereddy tylerjereddy changed the title MAINT: try 3.10rc wheels WIP, MAINT: try 3.10rc wheels Aug 13, 2021
@tylerjereddy
Copy link
Collaborator Author

Makes sense, we got blocked by that linear algebra testing issue for 4-5 versions of OpenBLAS I think, so all the attempts to bump failed. Looks like someone is chipping away at the issue a little at least.

@charris
Copy link
Contributor

charris commented Aug 14, 2021

NumPy will only build manylinux2014 wheels for 1.22. I'm also going to release manylinux2014 3.10 wheels for 1.21.2 so more people can start testing.

@charris
Copy link
Contributor

charris commented Aug 14, 2021

You also need cython >= 0.29.22, but might as well use the latest version 0.29.24.

@tylerjereddy
Copy link
Collaborator Author

Ah, I guess I had assumed I needed manylinux 2014, guess I can try removing that at least.

@tylerjereddy tylerjereddy force-pushed the treddy_try_python_310 branch from 0a07e27 to 45e268e Compare August 14, 2021 20:44
@tylerjereddy
MAINT: try 3.10rc wheels
0b1c064 
* mimic the approach used by NumPy wheels
in: MacPython/numpy-wheels#129

* what could go wrong.. (skip Travis for now)

[skip travis] [skip travis ci] [skip travis-ci] [travis skip]
@tylerjereddy tylerjereddy force-pushed the treddy_try_python_310 branch from 45e268e to 0b1c064 Compare August 14, 2021 20:47
@mattip
Copy link
Contributor

mattip commented Aug 14, 2021

manylinux 2014 is OK. There are two sides to moving off manylinux1 and manylinux2010:

  • Will people be able to use pip to install the manylinux2014 wheel (yes, since python3.10 comes with pip-21.1.3 which supports manyinux2014)?
  • does the glibc in the oldeset distro supported conform to manylinux2014/glibc2.17 (yes, since CenOS6 (manylinux2010, glibc 2.15) is EOL

@thomasjpfan thomasjpfan mentioned this pull request Sep 10, 2021
Closed
@tylerjereddy
Copy link
Collaborator Author

I'll close this--I think @tupui is going to try adding 3.10 now at @rgommers suggestion--for some reason I thought we might have some issues that we'd been avoiding with manylinux version bump but hopefully I"m wrong

@tupui tupui mentioned this pull request Sep 30, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tylerjereddy @charris @mattip