-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Phone number assignment cmdlet update #8942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phone number assignment cmdlet update #8942
Conversation
Docs Build status updates of commit b8dd342: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy review - @JensTrier, kindly commit the suggested changes. Many thanks.
Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
Docs Build status updates of commit 9f6e826: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Thanks & Done! |
Docs Build status updates of commit 7e91af4: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
@dariomws @tseward @get-itips |
@yogkumgit I would like to add the following info to the Outputs section with two examples. Can I do it in this PR or should I create a new one? On successful execution of the command no result object is present. On failed execution of the command, a result object is present with a Code string parameter to indicate the error code and a Message string parameter with the additional error or warning message. |
Hi @JensTrier, you can do it in this PR while it's still open. |
Docs Build status updates of commit 8fd085b: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
I've now added text to description section in both cmdlet files and added a new example to Set-CsPhoneNumberAssignment show the result object. Please have a look |
Docs Build status updates of commit 989b1ea: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
@JohanFreelancer9 @tseward @get-itips, please review the latest addition. |
@tiburd Please merge this PR. Thanks |
Docs Build status updates of commit 3235c19: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Added more descriptions to the 2 pages and fixed a typo