Skip to content

Conversation

JensTrier
Copy link
Contributor

Added more descriptions to the 2 pages and fixed a typo

@opbld33
Copy link

opbld33 commented Feb 11, 2022

Docs Build status updates of commit b8dd342:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Remove-CsPhoneNumberAssignment.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Set-CsPhoneNumberAssignment.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@JohanFreelancer9 JohanFreelancer9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy review - @JensTrier, kindly commit the suggested changes. Many thanks.

JensTrier and others added 5 commits February 14, 2022 08:52
Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
Co-authored-by: JohanFreelancer9 <48568725+JohanFreelancer9@users.noreply.github.com>
@opbld30
Copy link

opbld30 commented Feb 14, 2022

Docs Build status updates of commit 9f6e826:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Remove-CsPhoneNumberAssignment.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Set-CsPhoneNumberAssignment.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@JensTrier
Copy link
Contributor Author

Copy review - @JensTrier, kindly commit the suggested changes. Many thanks.

Thanks & Done!

@opbld30
Copy link

opbld30 commented Feb 14, 2022

Docs Build status updates of commit 7e91af4:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Remove-CsPhoneNumberAssignment.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Set-CsPhoneNumberAssignment.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@yogkumgit yogkumgit assigned dariomws and unassigned dariomws Feb 14, 2022
@yogkumgit yogkumgit requested review from dariomws, a user and get-itips February 14, 2022 16:09
@yogkumgit
Copy link

@dariomws @tseward @get-itips

@yogkumgit yogkumgit self-assigned this Feb 14, 2022
@JensTrier
Copy link
Contributor Author

@yogkumgit I would like to add the following info to the Outputs section with two examples. Can I do it in this PR or should I create a new one?

On successful execution of the command no result object is present. On failed execution of the command, a result object is present with a Code string parameter to indicate the error code and a Message string parameter with the additional error or warning message.

@dariomws
Copy link
Contributor

Hi @JensTrier, you can do it in this PR while it's still open.

@opbld32
Copy link

opbld32 commented Feb 15, 2022

Docs Build status updates of commit 8fd085b:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Remove-CsPhoneNumberAssignment.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Set-CsPhoneNumberAssignment.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@JensTrier
Copy link
Contributor Author

I've now added text to description section in both cmdlet files and added a new example to Set-CsPhoneNumberAssignment show the result object. Please have a look

@opbld31
Copy link

opbld31 commented Feb 15, 2022

Docs Build status updates of commit 989b1ea:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Remove-CsPhoneNumberAssignment.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Set-CsPhoneNumberAssignment.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@dariomws
Copy link
Contributor

@JohanFreelancer9 @tseward @get-itips, please review the latest addition.

@yogkumgit
Copy link

@tiburd Please merge this PR. Thanks

@opbld33
Copy link

opbld33 commented Feb 15, 2022

Docs Build status updates of commit 3235c19:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Remove-CsPhoneNumberAssignment.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Set-CsPhoneNumberAssignment.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@tiburd tiburd merged commit 6506581 into MicrosoftDocs:master Feb 15, 2022
@JensTrier JensTrier deleted the PhoneNumerAssignmentUpdate branch February 16, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.