Skip to content

Conversation

CalHoll
Copy link
Contributor

@CalHoll CalHoll commented Nov 7, 2022

This is causing some issues in builds that use this package as a transitive dependency. I'm not sure how it's coming up since it's just the example folder, but this bump in versions should fix the issue. More info here GetStream/stream-chat-flutter#1372

This is causing some issues in builds that use this package as a transitive dependency. I'm not sure how it's coming up since it's just the example folder, but this bump in versions should fix the issue. More info here GetStream/stream-chat-flutter#1372
@boyan01
Copy link
Contributor

boyan01 commented Nov 7, 2022

Hi, thanks for the PR, but I'm considering this change will not fix the issue GetStream/stream-chat-flutter#1372

Maybe it's more likely caused by this:

classpath 'com.android.tools.build:gradle:4.1.0'

@CalHoll
Copy link
Contributor Author

CalHoll commented Nov 7, 2022

Sorry been a long week! Not sure how I missed this but this clears up a lot of confusion. Possible to get this updated soon? After chasing down some obscure crashes in production it seems I need to update gradle and this dep is preventing the build.

@CalHoll
Copy link
Contributor Author

CalHoll commented Nov 7, 2022

Also these are not the latest versions, I tried to use the minimum compatible Kotlin version to make current builds work and guessed at gradle.

For what it's worth the latest versions are :
Kotlin: 1.7.20
Gradle: 7.3.1

Also I think this can be removed after latest versions are updated:
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"

@boyan01 boyan01 merged commit 833cda2 into MixinNetwork:main Nov 7, 2022
@boyan01
Copy link
Contributor

boyan01 commented Nov 7, 2022

Alread merged.

Maybe you can take a try by add this to you flutter project pubspec.yml

dependency_overrides:
  desktop_drop:
    git:
      url: https://github.com/MixinNetwork/flutter-plugins.git
      path: packages/desktop_drop
      ref: 833cda265f2b2e9fe4105d4c56386c5ccd82464a

@CalHoll
Copy link
Contributor Author

CalHoll commented Nov 7, 2022

Alread merged.

Maybe you can take a try by add this to you flutter project pubspec.yml

dependency_overrides:
  desktop_drop:
    git:
      url: https://github.com/MixinNetwork/flutter-plugins.git
      path: packages/desktop_drop
      ref: 833cda265f2b2e9fe4105d4c56386c5ccd82464a

This worked - THANK YOU!

@EchoEllet
Copy link
Contributor

EchoEllet commented Jul 11, 2024

A few things to consider:

  • I would suggest using ./gradlew wrapper --gradle-version=8.8 instead of changing the number directly in gradle/wrapper/gradle-wrapper.properties as this will update gradlew, gradlew.bat and the JAR file gradle/wrapper/gradle-wrapper.jar too.
  • I would also suggest using the same Kotlin version and Android Gradle Plugin (AGP) as the latest one tested by the Flutter Team, updating Kotlin requires projects to use a higher Kotlin version in the android platform project, we should consider using 1.7.10 for compatibility in case we don't use Kotlin language features above this version, updating Android Gradle Plugin cause many unexpected issues in Release Build, I wasn't able to detect what caused the issues, crashes and startup issues until I removed the android project, recreate it and move my changes, after some manual debugging it seems the issue that I updated Kotlin and AGP to the latest version, though I also did this in the blank Flutter project without any issues, so it might cause those issues with another plugin or more advance use cases, at the time of this PR, Flutter docs hasn't documented this common issue, in new releases (3.16 or 3.21), they will give you a warning when building the project to avoid such issues.

@boyan01
Copy link
Contributor

boyan01 commented Jul 12, 2024

@EchoEllet Thank you for the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants