Skip to content

Modal presentation issue after pull request #10075 #10115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
BozzaDaniel opened this issue Nov 30, 2022 · 4 comments · Fixed by #10153
Closed
3 tasks done

Modal presentation issue after pull request #10075 #10115

BozzaDaniel opened this issue Nov 30, 2022 · 4 comments · Fixed by #10153

Comments

@BozzaDaniel
Copy link

Issue Description

Following the merging of the pull request of #10075 the content of a modal is missing until the animation completes, see attached video, if the modal contains a frame. If no frame is present the content is visible.

With a frame in the modal:

Screen.Recording.2022-11-30.at.2.54.05.PM.mov

With no frame in the modal:

Screen.Recording.2022-11-30.at.2.55.20.PM.mov

This happens because it's pushing the content of the frame only after transitionCoordinator completes it's animation.

Reproduction

No response

Relevant log output (if applicable)

No response

Environment

No response

Please accept these terms
@BozzaDaniel BozzaDaniel added the bug-pending-triage Reported bug, pending triage to confirm. label Nov 30, 2022
@PedroAnibarro1
Copy link

Hi!

I'm having a similar issue.

RPReplay_Final1671451110.MP4

@CatchABus
Copy link
Contributor

@dgmachado I think that iOS #10075 patch needs a bit of tweaking.
It looks like there are modal animation problems.

@Woongsik
Copy link

Hi, I am suffering from this issue. Any updates for this?

NathanWalker added a commit that referenced this issue Jan 3, 2023
@NathanWalker
fix(ios): prevent transitionCoordinator usage during modal presentation
c9d819a 
closes #10115
@NathanWalker NathanWalker mentioned this issue Jan 3, 2023
Merged
4 tasks
@NathanWalker
Copy link
Contributor

@Woongsik fix for this will go out with 8.4.3 shortly with ref'd PR.

NathanWalker added a commit that referenced this issue Jan 3, 2023
@NathanWalker
fix(ios): prevent transitionCoordinator usage during modal presentati…
d138ac0 
…on (#10153)

closes #10115
@rigor789 rigor789 removed the bug-pending-triage Reported bug, pending triage to confirm. label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ios): prevent transitionCoordinator usage during modal presentation NativeScript/NativeScript
6 participants
@NathanWalker @rigor789 @PedroAnibarro1 @Woongsik @BozzaDaniel @CatchABus