Skip to content

ObservableArray does not provide removed items through EventData when an UPDATE action occurs #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ginev opened this issue Nov 24, 2015 · 1 comment · Fixed by #1154
Closed

ObservableArray does not provide removed items through EventData when an UPDATE action occurs #1142

ginev opened this issue Nov 24, 2015 · 1 comment · Fixed by #1154
Labels
bug done
Milestone
1.5.1

Comments

@ginev
Copy link

ginev commented Nov 24, 2015

Here's a snippet from ObservableArray.js:

     ObservableArray.prototype.setItem = function (index, value) {
        this._array[index] = value;
        this.notify({
            eventName: CHANGE, object: this,
            action: ChangeType.Update,
            index: index,
            removed: new Array(1),
            addedCount: 1
        });
    };

The following line: removed: new Array(1) is the one I am talking about.
@ginev ginev added the bug label Nov 24, 2015
@enchev enchev self-assigned this Nov 25, 2015
@enchev enchev added this to the 1.6 (Under Review) milestone Nov 25, 2015
@enchev enchev mentioned this issue Nov 25, 2015
Merged
@enchev enchev added the done label Nov 25, 2015
@atanasovg atanasovg modified the milestones: 1.5.1 (Under Review), 1.5.1 Nov 26, 2015
@lock
Copy link

lock bot commented Aug 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot unassigned enchev Aug 30, 2019
@lock lock bot locked and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug done
Projects
None yet
Milestone
1.5.1
Development

Successfully merging a pull request may close this issue.

setItem event fixed NativeScript/NativeScript
3 participants
@enchev @ginev @atanasovg