Skip to content

[TabView] Tabitem title not measured/arranged properly in a modal dialog with root tabview inside #5392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
manoldonev opened this issue Feb 6, 2018 · 1 comment · Fixed by #5435
Closed

[TabView] Tabitem title not measured/arranged properly in a modal dialog with root tabview inside #5392

manoldonev opened this issue Feb 6, 2018 · 1 comment · Fixed by #5435
Assignees
@manoldonev
Labels
ns-next os: android
Milestone
4.0

Comments

@manoldonev
Copy link
Contributor

manoldonev commented Feb 6, 2018 •
edited
Loading

Which platform(s) does your issue occur on?

Android

Please provide the following version numbers that your issue occurs with:

  • CLI: 3.4.1
  • Cross-platform modules: 4.0.0

Please tell us how to recreate the issue in as much detail as possible.

Second tabItem title is not measured/arranged properly and gets wrapped in a scenario with opening a modal dialog with root tabview visual inside. Note that the problem is only present if the modal dialog is opened with fullscreen flag set to false.

See the attached screenshot (can be reproduced in e2e/modal-navigation):

screenshot_1517935730
@manoldonev manoldonev added this to the 4.0 milestone Feb 12, 2018
@manoldonev manoldonev self-assigned this Feb 12, 2018
@manoldonev manoldonev mentioned this issue Feb 19, 2018
Merged
@ghost ghost added the in progress label Feb 19, 2018
@manoldonev manoldonev changed the title Tabitem title not measured/arranged properly in a modal dialog with root tabview inside [TabView] Tabitem title not measured/arranged properly in a modal dialog with root tabview inside Feb 19, 2018
@ghost ghost removed bug in progress labels Mar 2, 2018
manoldonev added a commit that referenced this issue Mar 2, 2018
@manoldonev
fix-next(tabview): fix tab title layout in modal root tabview Fixes #…
9214883 
…5392 (#5435)

BREAKING CHANGE: [Android] NativeScript no longer overwrites the horizontal/vertical alignment on the user-defined root visual element when opening it in modal dialog window (i.e. not fullscreen).

If your application logic relied on the previous behavior you need to manually set `horizontalAlignment="center"` and `verticalAlignment="middle"` on the root visual element you are showing modally.
@lock
Copy link

lock bot commented Aug 27, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@manoldonev manoldonev

Labels
ns-next os: android
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

fix-next(tabview): fix tab title layout in modal root tabview Fixes #5392 NativeScript/NativeScript
1 participant
@manoldonev