fix-next(tabview): fix tab title layout in modal root tabview Fixes #5392 #5435
Conversation
9261ba9 to
aed1044
Compare
|
Another approach that might worth considering: Doing the wrap with the additional gird layout in the DialogFragment when showing the dialog (somewhere here). This will probably prevent similar problems with other views hosted inside a dialog fragment. |
aed1044 to
1ff9bb7
Compare
0b140c6 to
4af6e72
Compare
|
Thanks for the tip @hshristov 👍 Indeed those explicit alignment setters are the root cause of the problem and not |
d175deb to
58535fe
Compare
| <Page xmlns="http://schemas.nativescript.org/tns.xsd" shownModally="onShownModally" loaded="onLoaded" unloaded="onUnloaded" backgroundColor="Red"> | ||
| <Page xmlns="http://schemas.nativescript.org/tns.xsd" shownModally="onShownModally" | ||
| loaded="onLoaded" unloaded="onUnloaded" backgroundColor="Red" | ||
| horizontalAlignment="center" verticalAlignment="middle"> |
There was a problem hiding this comment.
This change is required as we no longer force alignment settings on user content unless it is absolutely necessary i.e. if fullscreen dialog is requested we would override these and stretch the user content.
58535fe to
06b634d
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #5392
See comments below.
In a modal dialog scenario with root tabview inside, the DialogFragment content at some point is set via PhoneWindow.setContentView(view) call whereviewis the gridLayout root element of the tabview. This results insetContentView(view, new ViewGroup.LayoutParams(MATCH_PARENT, MATCH_PARENT))call that unconditionally overwrites the default instance of CommonLayoutParams attached to the gridLayout by us. As the default setter essentially creatednew ViewGroup.LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT, Gravity.FILL)we lose the Gravity.FILL setting and that prevents the gridLayout from stretching horizontally so tab item titles do not distribute the excess whitespace among themselves.The proposed solution is to add a no-op outer native wrapper element to be laid out by the DialogFragment so we can perform the layout of the innergridLayoutelement as expected.Alternatively (as this problem is related only to modal dialog scenarios and I do not like the solution very much) we can make no changes to the tabview codebase and instruct those devs that hit the problem to add the additional GridLayout wrapper element by themselves in their own application code (the drawback is that it looks "broken" out-of-the-box).Also, @MartoYankov pointed out something else that we might consider at some point -- generally the problem here is triggered by https://github.com/NativeScript/tns-core-modules-widgets/blob/a9ac20da20422ae57aa4cfa76bc03dc27d6bc885/android/widgets/src/main/java/org/nativescript/widgets/GridLayout.java#L259 in the GridLayout codebase that decides how the grid layout should behave based on a setting of its own LayoutParams while Android documentation states that "LayoutParams are used by views to tell their parents how they want to be laid out".
BREAKING CHANGE: [Android] NativeScript no longer overwrites the horizontal/vertical alignment on the user-defined root visual element when opening it in modal dialog window (i.e. not fullscreen).
If your application logic relied on the previous behavior you need to manually set
horizontalAlignment="center"andverticalAlignment="middle"on the root visual element you are showing modally.