fix(application): rootView undefined on resume #10345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
The commit ab5fa94 seems to have broken the resume of the app in some situations, e.g. when switching back from nativescript-inappbrowser. As illustrated by this repo.
On closing the browser you get a crash on android with the stack:
The reason is that the application.foregroundActivity is undefined, and the startActivity is a chromeManagerActivity, and the code then fails to resolve the rootView.
What is the new behavior?
This change modifies
initRootView
to accept a root view, since all calling code seems to already have the rootView and can pass it in.