Skip to content

fix(android): Background color is not applied to certain views #10652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

CatchABus
Copy link
Contributor

@CatchABus CatchABus commented Nov 17, 2024

PR Checklist

What is the current behavior?

This is a fix for a bug caused by #10451.
It seems some android views with background drawable will not render the drawable color filter (e.g. Material design bottom navigation bar).

What is the new behavior?

From now on, we mark the views that need setting the drawable color and call setBackgroundColor as a default for the rest of them.
Getter needsNativeDrawableFill seems like a good way to distinguish those views and we might be able to use it on iOS if such a case arises.

See relevant discussion: https://discord.com/channels/603595811204366337/1019708793371770950/threads/1300825437882290177

@NathanWalker NathanWalker merged commit 4f36748 into NativeScript:main Nov 19, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants