fix(android): Background color is not applied to certain views #10652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
This is a fix for a bug caused by #10451.
It seems some android views with background drawable will not render the drawable color filter (e.g. Material design bottom navigation bar).
What is the new behavior?
From now on, we mark the views that need setting the drawable color and call
setBackgroundColor
as a default for the rest of them.Getter
needsNativeDrawableFill
seems like a good way to distinguish those views and we might be able to use it on iOS if such a case arises.See relevant discussion: https://discord.com/channels/603595811204366337/1019708793371770950/threads/1300825437882290177