fix(ios): Safe area memory leak on iOS 10 and older versions #10673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

NathanWalker merged 2 commits into NativeScript:main from CatchABus:fix/ios-10-safe-area-leak

Jan 22, 2025

Contributor

CatchABus commented Jan 22, 2025

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

In iOS 10 and earlier versions, custom implementation of safeAreaLayoutGuide causes memory leaks.

What is the new behavior?

Custom safeAreaLayoutGuide and its constraints will be created once.


          fix(ios): Safe area memory leak on iOS 10 and older versions

9873aa9

NathanWalker added this to the 8.9 milestone

NathanWalker approved these changes

View reviewed changes


          Merge branch 'main' into fix/ios-10-safe-area-leak

NathanWalker merged commit 0eb2745 into NativeScript:main

0 of 3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet