Skip to content

fix(ios): Safe area memory leak on iOS 10 and older versions #10673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2025
Merged

fix(ios): Safe area memory leak on iOS 10 and older versions #10673

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9873aa9
fix(ios): Safe area memory leak on iOS 10 and older versions
CatchABus Jan 22, 2025
0604236
Merge branch 'main' into fix/ios-10-safe-area-leak
NathanWalker Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 25 additions & 7 deletions packages/core/ui/core/view/view-helper/index.ios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,20 +200,38 @@ export class IOSHelper {
}
}

/**
* This method simulates the iOS 11+ safeAreaLayoutGuide property and its constraints for older versions.
*
* @param controller
* @param owner
*/
static updateConstraints(controller: UIViewController, owner: View): void {
if (!__VISIONOS__ && SDK_VERSION <= 10) {
const layoutGuide = IOSHelper.initLayoutGuide(controller);
(<any>controller.view).safeAreaLayoutGuide = layoutGuide;
if (!controller.view.safeAreaLayoutGuide) {
IOSHelper.initLayoutGuide(controller);
}
}
}

static initLayoutGuide(controller: UIViewController) {
/**
* This method simulates the iOS 11+ safeAreaLayoutGuide property for older versions.
*
* @param controller
*/
static initLayoutGuide(controller: UIViewController): UILayoutGuide {
const rootView = controller.view;
const layoutGuide = UILayoutGuide.new();
rootView.addLayoutGuide(layoutGuide);
NSLayoutConstraint.activateConstraints(<any>[layoutGuide.topAnchor.constraintEqualToAnchor(controller.topLayoutGuide.bottomAnchor), layoutGuide.bottomAnchor.constraintEqualToAnchor(controller.bottomLayoutGuide.topAnchor), layoutGuide.leadingAnchor.constraintEqualToAnchor(rootView.leadingAnchor), layoutGuide.trailingAnchor.constraintEqualToAnchor(rootView.trailingAnchor)]);

return layoutGuide;
if (!rootView.safeAreaLayoutGuide) {
const layoutGuide = UILayoutGuide.new();

rootView.addLayoutGuide(layoutGuide);
NSLayoutConstraint.activateConstraints([layoutGuide.topAnchor.constraintEqualToAnchor(controller.topLayoutGuide.bottomAnchor), layoutGuide.bottomAnchor.constraintEqualToAnchor(controller.bottomLayoutGuide.topAnchor), layoutGuide.leadingAnchor.constraintEqualToAnchor(rootView.leadingAnchor), layoutGuide.trailingAnchor.constraintEqualToAnchor(rootView.trailingAnchor)]);

(<any>rootView).safeAreaLayoutGuide = layoutGuide;
}

return rootView.safeAreaLayoutGuide;
}

static layoutView(controller: UIViewController, owner: View): void {
Expand Down
Loading