fix(android): Formatted string NoSuchMethodError #10704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

NathanWalker merged 1 commit into NativeScript:main from CatchABus:fix/android-typeface-span

Feb 21, 2025

Contributor

CatchABus commented Feb 21, 2025 •

edited

Loading

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

Right now, android FormattedString throws exception due to using a TypeFaceSpan constructor that's available since API 28.

What is the new behavior?

Reverted most CustomTypeFaceSpan class changes done in PR #10682 including the constructor that's faulty for older devices.

Fixes/Implements/Closes #10702.


          fix(android): Formatted string NoSuchMethodError

CatchABus force-pushed the fix/android-typeface-span branch from 1bc4899 to 5798025 Compare

February 21, 2025 19:10

NathanWalker approved these changes

View reviewed changes

NathanWalker merged commit 3587917 into NativeScript:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet