Skip to content

feat(core): TextBase Span interaction and styling improvements #10682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

CatchABus
Copy link
Contributor

@CatchABus CatchABus commented Jan 31, 2025

PR Checklist

What is the new behavior?

This PR enhances some points around TextBase Span interaction and view disposal.
More specifically:

  • Added linkTap event support for other iOS views that nest spans
  • Prevent android span from setting parent background color to itself since it doesn't react to changes of that property. Unless background color is specified to the span directly, it's going to be transparent
  • Added few missing nativeTextViewProtected references
  • Improved view disposal for classes that inherit from TextBase as they had leftovers after android activity recreation
  • Removed 2 assignments of userInteractionEnabled from TextBase as they were unneeded and had conflicts with isUserInteractionEnabled property. Core already sets that property to true for the views that need it in createNativeView call
  • HTMLView will remove extra padding using the documented UIEdgeInsetsZero

@NathanWalker NathanWalker added this to the 8.9 milestone Jan 31, 2025
@NathanWalker NathanWalker merged commit 966dccd into NativeScript:main Jan 31, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants