fix(hmr): close modal views during livesync #7669
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88d719e to
ae9ecff
Compare
MartoYankov
reviewed
Aug 12, 2019
added 3 commits
August 12, 2019 10:07
chore: expose method that closes all modal views of a view
5 tasks
MartoYankov
approved these changes
Aug 12, 2019
MartoYankov
reviewed
Aug 13, 2019
added 3 commits
August 13, 2019 13:31
chore: add unit tests to test that modal views are closed during hmr
vchimev
reviewed
Aug 14, 2019
tests/app/livesync/livesync-tests.ts
Outdated
|
|
||
| TKUnit.waitUntilReady(() => !!frame.topmost()); | ||
| const topmostFrame = frame.topmost(); | ||
| TKUnit.waitUntilReady(() => topmostFrame.currentPage && topmostFrame.currentPage.isLoaded); |
There was a problem hiding this comment.
I would add topmostFrame.canGoBack() to make sure the app hasn't restarted.
vchimev
reviewed
Aug 14, 2019
tests/app/livesync/livesync-tests.ts
Outdated
| @@ -209,6 +236,18 @@ function _test_onLiveSync_ModuleReplace_Multiple(context: ModuleContext[]) { | |||
| TKUnit.assertEqual(pageBeforeNavigation, pageAfterBackNavigation, "Pages are different!"); | |||
| } | |||
|
|
|||
| function _test_onLiveSync_ModalViewClosed(context: ModuleContext) { | |||
| const buttonPage = <Page>createViewFromEntry(({ moduleName: modalViewPageModuleName })); | |||
There was a problem hiding this comment.
buttonPage is more like modalViewPage ;)
|
Closing this PR in favor of #7679 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Any opened modal views are not updated or closed during HMR livesync
What is the new behavior?
Any opened modal views are closed during HMR livesync
Fixes/Implements/Closes #[Issue Number].
#7668