Skip to content

fix(core): iOS app memory leak after using the 'presentViewController… #9934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 16, 2022
Merged

fix(core): iOS app memory leak after using the 'presentViewController… #9934

merged 6 commits into from
Jun 16, 2022

Conversation

dgmachado
Copy link
Contributor

@dgmachado dgmachado commented Jun 10, 2022 •
edited
Loading

…' navigation

PR Checklist

What is the current behavior?

The iOS app is leaking always after using the 'presentViewController' navigation for Frame. According to the debugging, the entire frame presented is leaking.

What is the new behavior?

The frame presented by the 'presentViewController' navigation is being disposed of memory.

@cla-bot
Copy link

cla-bot bot commented Jun 10, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Douglas Machado.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Jun 10, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Douglas Machado.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

edusperoni
edusperoni reviewed Jun 10, 2022
View reviewed changes
@cla-bot
Copy link

cla-bot bot commented Jun 10, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Douglas Machado.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot cla-bot bot added the cla: yes label Jun 10, 2022
@NathanWalker NathanWalker changed the base branch from master to alpha June 16, 2022 20:26
@NathanWalker NathanWalker merged commit edc2e6a into NativeScript:alpha Jun 16, 2022
NathanWalker pushed a commit that referenced this pull request Jul 9, 2022
@dgmachado @NathanWalker
fix(ios): memory leak after using the 'presentViewControllerNavigatio…
2cb173b 
…n' (#9934)
NathanWalker pushed a commit that referenced this pull request Jul 9, 2022
@dgmachado @NathanWalker
fix(ios): memory leak after using the 'presentViewControllerNavigatio…
957af32 
…n' (#9934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edusperoni edusperoni edusperoni left review comments

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgmachado @edusperoni @NathanWalker