Skip to content

chore: add background color to modal in example #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2019

Conversation

VladimirAmiorkov
Copy link
Contributor

PR Checklist

What is the current behavior?

Modal window in iOS 13 is transparent.

What is the new behavior?

Modal window in iOS 13 is not transparent. In iOS 13 the style of the modals has changed and we need ot explicitly set the backgroundColor of the first element that is passed to showModal

Fixes/Implements/Closes #[Issue Number].
Resolves #2012

@VladimirAmiorkov VladimirAmiorkov self-assigned this Oct 23, 2019
@cla-bot cla-bot bot added the cla: yes label Oct 23, 2019
tbozhikov
tbozhikov previously approved these changes Oct 23, 2019
@VladimirAmiorkov VladimirAmiorkov merged commit 064f71f into master Oct 24, 2019
@VladimirAmiorkov VladimirAmiorkov deleted the amiorkov/ios13-modals-fix branch October 24, 2019 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS 13] Modal lazy loaded background is transparent on iOS 13
4 participants