Skip to content

chore: add background color to modal in example #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2019
Merged

chore: add background color to modal in example #2034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9f23e4
chore: add background color to modal in example
Oct 23, 2019
daa77b4
chore: revert the change tothe version of nativescript-dev-webpack in…
Oct 23, 2019
0f3dccd
Merge branch 'master' into amiorkov/ios13-modals-fix
DimitarTodorov Oct 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions e2e/tests-app-ng/app/lazy/lazy.component.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@

.system-background-color-stack-layout {
background-color: white;
}

.ns-dark .system-background-color-stack-layout {
background-color: gray;
}
2 changes: 1 addition & 1 deletion e2e/tests-app-ng/app/lazy/lazy.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<StackLayout>
<StackLayout class="system-background-color-stack-layout">
<GridLayout rows="auto" columns="auto" [visibility]="isModal ? 'visible' : 'collapsed'">
<Button
automationText="closeModal"
Expand Down
1 change: 1 addition & 0 deletions e2e/tests-app-ng/app/lazy/lazy.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { ModalDialogParams } from "nativescript-angular/directives/dialogs";
selector: "ns-lazy",
moduleId: module.id,
templateUrl: "./lazy.component.html",
styleUrls: ["./lazy.component.css"]
})
export class LazyComponent {
public isModal: boolean;
Expand Down
2 changes: 1 addition & 1 deletion e2e/tests-app-ng/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"@angular/platform-browser": "~8.2.0",
"@angular/platform-browser-dynamic": "~8.2.0",
"@angular/router": "~8.2.0",
"nativescript-angular": "file:../../nativescript-angular",
"nativescript-angular": "file:../../nativescript-angular-package",
"nativescript-intl": "~3.0.0",
"nativescript-theme-core": "^1.0.4",
"reflect-metadata": "~0.1.8",
Expand Down
3 changes: 3 additions & 0 deletions e2e/tests-app-ng/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,13 @@
}
},
"include": [
"../../nativescript-angular-package",
"../../nativescript-angular",
"**/*"
],
"exclude": [
"../../nativescript-angular-package/node_modules",
"../../nativescript-angular-package/**/*.d.ts",
"../../nativescript-angular/node_modules",
"../../nativescript-angular/**/*.d.ts",
"node_modules",
Expand Down