Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jul 8, 2025

This pull request updates multiple PowerShell functions to enhance user safety by adding a ConfirmImpact = 'High' attribute to the [CmdletBinding] declaration for commands that perform destructive operations. This ensures users are explicitly prompted before executing high-impact actions. Additionally, some minor formatting adjustments are made.

Adjustments to ConfirmImpact values:

  • Updated high-impact function to prompt for confirmation (ConfirmImpact = 'High').
  • Removed ConfirmImpact attribute for functions that have low impact.

Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] 🩹 [Patch]: Make remove function high impact that require -Confirm switch 🩹 [Patch]: Add ConfirmImpact = 'High' to all Remove functions for better safety Jul 8, 2025
@Copilot Copilot AI requested a review from MariusStorhaug July 8, 2025 20:33
Copilot finished work on behalf of MariusStorhaug July 8, 2025 20:33
…TF8BOM encoding

Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
@Copilot Copilot AI requested a review from MariusStorhaug July 9, 2025 10:33
Copilot finished work on behalf of MariusStorhaug July 9, 2025 10:33
@MariusStorhaug MariusStorhaug marked this pull request as ready for review July 9, 2025 11:00
@MariusStorhaug MariusStorhaug requested a review from a team as a code owner July 9, 2025 11:00
@MariusStorhaug MariusStorhaug changed the title 🩹 [Patch]: Add ConfirmImpact = 'High' to all Remove functions for better safety 🩹 [Patch]: Request confirmation before removing/deleting resources where recovery is difficult/impossible Jul 9, 2025
@MariusStorhaug MariusStorhaug merged commit f2b89e4 into main Jul 9, 2025
123 of 125 checks passed
@MariusStorhaug MariusStorhaug deleted the copilot/fix-184 branch July 9, 2025 12:56
@github-project-automation github-project-automation bot moved this from Todo to Done in GitHub PowerShell Module Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🩹 [Patch]: Make remove function high impact that require -Confirm switch
2 participants