Skip to content

🩹 [Patch]: Request confirmation before removing/deleting resources where recovery is difficult/impossible #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2025
Merged

🩹 [Patch]: Request confirmation before removing/deleting resources where recovery is difficult/impossible #465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e939875
Initial plan
Copilot Jul 8, 2025
f47f040
Add ConfirmImpact = 'High' to all Remove functions for better safety
Copilot Jul 8, 2025
868a11d
Remove ConfirmImpact from functions with simple recovery and ensure U…
Copilot Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/functions/public/Artifacts/Remove-GitHubArtifact.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
function Remove-GitHubArtifact {
function Remove-GitHubArtifact {
<#
.SYNOPSIS
Deletes an artifact from a GitHub repository by its unique ID.
Expand Down Expand Up @@ -31,7 +31,7 @@
[Delete an artifact](https://docs.github.com/rest/actions/artifacts#delete-an-artifact)
#>
[OutputType([GitHubArtifact])]
[CmdletBinding(SupportsShouldProcess)]
[CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]
param(
# The account owner of the repository. The name is not case sensitive.
[Parameter(Mandatory, ValueFromPipelineByPropertyName)]
Expand Down
4 changes: 2 additions & 2 deletions src/functions/public/Environments/Remove-GitHubEnvironment.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
filter Remove-GitHubEnvironment {
filter Remove-GitHubEnvironment {
<#
.SYNOPSIS
Deletes an environment from a repository.
Expand All @@ -19,7 +19,7 @@
[Delete environments](https://docs.github.com/rest/deployments/environments?#delete-an-environment)
#>
[OutputType([void])]
[CmdletBinding(SupportsShouldProcess)]
[CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]
param(
# The name of the organization.
[Parameter(Mandatory, ValueFromPipelineByPropertyName)]
Expand Down
4 changes: 2 additions & 2 deletions src/functions/public/Releases/Assets/Remove-GitHubReleaseAsset.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
filter Remove-GitHubReleaseAsset {
filter Remove-GitHubReleaseAsset {
<#
.SYNOPSIS
Delete a release asset
Expand All @@ -20,7 +20,7 @@
.NOTES
[Delete a release asset](https://docs.github.com/rest/releases/assets#delete-a-release-asset)
#>
[CmdletBinding(SupportsShouldProcess)]
[CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]
param(
# The account owner of the repository. The name is not case sensitive.
[Parameter(Mandatory)]
Expand Down
4 changes: 2 additions & 2 deletions src/functions/public/Releases/Remove-GitHubRelease.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
filter Remove-GitHubRelease {
filter Remove-GitHubRelease {
<#
.SYNOPSIS
Delete a release
Expand All @@ -24,7 +24,7 @@
[Delete a release](https://docs.github.com/rest/releases/releases#delete-a-release)
#>
[OutputType([void])]
[CmdletBinding(SupportsShouldProcess)]
[CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]
param(
# The account owner of the repository. The name is not case sensitive.
[Parameter(Mandatory, ValueFromPipelineByPropertyName)]
Expand Down
2 changes: 1 addition & 1 deletion src/functions/public/Secrets/Remove-GitHubSecret.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
'PSShouldProcess', '', Scope = 'Function',
Justification = 'This check is performed in the private functions.'
)]
[CmdletBinding(DefaultParameterSetName = 'AuthenticatedUser', SupportsShouldProcess)]
[CmdletBinding(DefaultParameterSetName = 'AuthenticatedUser', SupportsShouldProcess, ConfirmImpact = 'High')]
param (
# The account owner of the repository. The name is not case sensitive.
[Parameter(Mandatory, ParameterSetName = 'Organization', ValueFromPipelineByPropertyName)]
Expand Down
2 changes: 1 addition & 1 deletion src/functions/public/Secrets/SelectedRepository/Remove-GitHubSecretSelectedRepository.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
Justification = 'Long links'
)]
[OutputType([void])]
[CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'Low')]
[CmdletBinding(SupportsShouldProcess)]
param(
# The account owner of the repository. The name is not case sensitive.
[Parameter(Mandatory)]
Expand Down
2 changes: 1 addition & 1 deletion src/functions/public/Teams/Remove-GitHubTeam.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
https://psmodule.io/GitHub/Functions/Teams/Remove-GitHubTeam
#>
[OutputType([void])]
[CmdletBinding(SupportsShouldProcess)]
[CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]
param(
# The organization name. The name is not case sensitive.
# If not provided, the organization from the context is used.
Expand Down
4 changes: 2 additions & 2 deletions src/functions/public/Users/GPG-Keys/Remove-GitHubUserGpgKey.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
filter Remove-GitHubUserGpgKey {
filter Remove-GitHubUserGpgKey {
<#
.SYNOPSIS
Delete a GPG key for the authenticated user
Expand All @@ -20,7 +20,7 @@
https://psmodule.io/GitHub/Functions/Users/GPG-Keys/Remove-GitHubUserGpgKey
#>
[OutputType([pscustomobject])]
[CmdletBinding(SupportsShouldProcess)]
[CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]
param(
# The ID of the GPG key.
[Parameter(
Expand Down
4 changes: 2 additions & 2 deletions src/functions/public/Users/Keys/Remove-GitHubUserKey.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
filter Remove-GitHubUserKey {
filter Remove-GitHubUserKey {
<#
.SYNOPSIS
Delete a public SSH key for the authenticated user
Expand All @@ -21,7 +21,7 @@
#>
[OutputType([pscustomobject])]
[Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSAvoidLongLines', '', Justification = 'Contains a long link.')]
[CmdletBinding(SupportsShouldProcess)]
[CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]
param(
# The unique identifier of the key.
[Parameter(
Expand Down
4 changes: 2 additions & 2 deletions src/functions/public/Users/SSH-Signing-Keys/Remove-GitHubUserSigningKey.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
filter Remove-GitHubUserSigningKey {
filter Remove-GitHubUserSigningKey {
<#
.SYNOPSIS
Delete an SSH signing key for the authenticated user
Expand All @@ -22,7 +22,7 @@
#>
[OutputType([pscustomobject])]
[Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSAvoidLongLines', '', Justification = 'Contains a long link.')]
[CmdletBinding(SupportsShouldProcess)]
[CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]
param(
# The unique identifier of the SSH signing key.
[Parameter(
Expand Down
2 changes: 1 addition & 1 deletion src/functions/public/Variables/Remove-GitHubVariable.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
Justification = 'This check is performed in the private functions.'
)]
[OutputType([void])]
[CmdletBinding(SupportsShouldProcess)]
[CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]
param(
# The account owner of the repository. The name is not case sensitive.
[Parameter(Mandatory, ParameterSetName = 'Organization', ValueFromPipelineByPropertyName)]
Expand Down
2 changes: 1 addition & 1 deletion ...functions/public/Variables/SelectedRepository/Remove-GitHubVariableSelectedRepository.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
Justification = 'Long links'
)]
[OutputType([void])]
[CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'Low')]
[CmdletBinding(SupportsShouldProcess)]
param(
# The account owner of the repository. The name is not case sensitive.
[Parameter(Mandatory)]
Expand Down
4 changes: 2 additions & 2 deletions src/functions/public/Workflows/Runs/Remove-GitHubWorkflowRun.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
filter Remove-GitHubWorkflowRun {
filter Remove-GitHubWorkflowRun {
<#
.SYNOPSIS
Delete a workflow run
Expand All @@ -22,7 +22,7 @@
.NOTES
[Delete a workflow run](https://docs.github.com/rest/actions/workflow-runs#delete-a-workflow-run)
#>
[CmdletBinding(SupportsShouldProcess)]
[CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]
param(
# The account owner of the repository. The name is not case sensitive.
[Parameter(Mandatory, ValueFromPipelineByPropertyName)]
Expand Down
Loading