Skip to content

🩹 [Patch]: Check for proc count #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 13, 2024
Merged

🩹 [Patch]: Check for proc count #50

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3adab39
use [System.Environment]::ProcessorCount instead of $env:NUMBER_OF_PR…
MariusStorhaug Apr 13, 2024
46bf4f8
Add a test
MariusStorhaug Apr 13, 2024
8d5833c
test
MariusStorhaug Apr 13, 2024
09e79ef
test
MariusStorhaug Apr 13, 2024
646dbc2
FIx
MariusStorhaug Apr 13, 2024
49606ab
Refactor New-PSModuleTest function to remove unused code
MariusStorhaug Apr 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion scripts/tests/PSModule/SourceCode.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,14 @@ Param(
[string] $Path
)

BeforeAll {
[Diagnostics.CodeAnalysis.SuppressMessageAttribute(
'PSUseDeclaredVarsMoreThanAssignments', 'scriptFiles',
Justification = 'scriptFiles is used in the test.'
)]
$scriptFiles = Get-ChildItem -Path $Path -Filter '*.ps1' -Recurse -File
}

Describe 'PSModule - SourceCode tests' {

Context 'function/filter' {
Expand All @@ -34,7 +42,7 @@ Describe 'PSModule - SourceCode tests' {
" - $($_.filePath): Function/filter name [$($_.functionName)]. Change file name or function/filter name so they match."
}
$issues -join [Environment]::NewLine |
Should -BeNullOrEmpty -Because 'the script files should be called the same as the function they contain'
Should -BeNullOrEmpty -Because 'the script files should be called the same as the function they contain'
}

# It 'Script file should only contain one function or filter' {}
Expand Down Expand Up @@ -67,4 +75,22 @@ Describe 'PSModule - SourceCode tests' {
# It 'datatype for parameters and parameter name are separated by a single space' {}
# It 'parameters are separated by a blank line' {}
}

Context 'Compatability checks' {
It "Should use '[System.Environment]::ProcessorCount' instead of '$env:NUMBER_OF_PROCESSORS'" {
$issues = @('')
$scriptFiles | ForEach-Object {
Select-String -Path $_.FullName -Pattern '\$env:NUMBER_OF_PROCESSORS' -AllMatches | ForEach-Object {
$issues += " - $($_.Path):L$($_.LineNumber)"
}
}
$issues -join [Environment]::NewLine |
Should -BeNullOrEmpty -Because 'the script should use [System.Environment]::ProcessorCount instead of $env:NUMBER_OF_PROCESSORS'
}
}

Context 'Module manifest' {
# It 'Module Manifest exists (maifest.psd1 or modulename.psd1)' {}
# It 'Module Manifest is valid' {}
}
}