Skip to content

Add alpine CI workflow for x86. #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Add alpine CI workflow for x86. #1230

merged 2 commits into from
Aug 26, 2024

Conversation

iddm
Copy link
Collaborator

@iddm iddm commented Aug 16, 2024

No description provided.

@iddm iddm self-assigned this Aug 16, 2024
@iddm iddm force-pushed the support-alpine branch 6 times, most recently from db5e93b to db89836 Compare August 16, 2024 11:28
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.37%. Comparing base (bfb657b) to head (c201ce4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1230   +/-   ##
=======================================
  Coverage   78.37%   78.37%           
=======================================
  Files          14       14           
  Lines        3921     3921           
=======================================
  Hits         3073     3073           
  Misses        848      848           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iddm iddm force-pushed the support-alpine branch 4 times, most recently from d7c2728 to f4e13a4 Compare August 16, 2024 12:00
Copy link
Collaborator

@ephraimfeldblum ephraimfeldblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a working example of this flow? I'd appreciate seeing it building and running before signing off on it.

@iddm
Copy link
Collaborator Author

iddm commented Aug 19, 2024

Is there a working example of this flow? I'd appreciate seeing it building and running before signing off on it.

Is there a working example of this flow? I'd appreciate seeing it building and running before signing off on it.

Just as the others, like "mariner" the code is written to only support the branch name, not pull requests. So no, it will only work until make pack. You can find the pipeline which failed at this step.

Mariner was added the same way, by the way: #1102

@iddm
Copy link
Collaborator Author

iddm commented Aug 19, 2024

@ephraimfeldblum
screenshot

@iddm iddm changed the title Add alpine CI workflow. Add alpine CI workflow for x86. Aug 26, 2024
@iddm iddm merged commit 8d8471d into master Aug 26, 2024
12 checks passed
@iddm iddm deleted the support-alpine branch August 26, 2024 09:26
iddm added a commit that referenced this pull request Aug 27, 2024
iddm added a commit that referenced this pull request Aug 27, 2024
iddm added a commit that referenced this pull request Aug 27, 2024
* Add alpine CI workflow. (#1230)

* Move ubuntu docker builds from CircleCI to GHA. (#1234)

* Move ubuntu docker builds from CircleCI to GHA.

* Try building Redis in parallel and use newer AWS creds

* Restrict the ubuntu docker CI only for merges/tags.
iddm added a commit that referenced this pull request Aug 27, 2024
* Add alpine CI workflow. (#1230)

* Move ubuntu docker builds from CircleCI to GHA. (#1234)

* Move ubuntu docker builds from CircleCI to GHA.

* Try building Redis in parallel and use newer AWS creds

* Restrict the ubuntu docker CI only for merges/tags.
iddm added a commit that referenced this pull request Aug 27, 2024
* Add alpine CI workflow. (#1230)

* Move ubuntu docker builds from CircleCI to GHA. (#1234)

* Move ubuntu docker builds from CircleCI to GHA.

* Try building Redis in parallel and use newer AWS creds

* Restrict the ubuntu docker CI only for merges/tags.
iddm added a commit that referenced this pull request Aug 27, 2024
* Fix the CI issues. (#1231) (#1233)

Fix the CI by updating the macos version.

* Fix the CI. (#1238)

* Add alpine CI workflow. (#1230)

* Move ubuntu docker builds from CircleCI to GHA. (#1234)

* Move ubuntu docker builds from CircleCI to GHA.

* Try building Redis in parallel and use newer AWS creds

* Restrict the ubuntu docker CI only for merges/tags.

* Update the dependencies

* Backport fixes from 2.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants