-
Notifications
You must be signed in to change notification settings - Fork 332
[2.0] Rebase from master #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* json.get returns a top-level array (as bulk string) * Fix format and tests
* added generic json path implementation * fix build * fix fmt * move jsonpath changes to jsonpath_lib repository * fix format * WIP: generic impl * fix format * better error message * added json.del generic impl * added generic impl for json.mget and json.type * generic impl for all num operations * fix format * genric impl for all the commands * unified json resp impl * use macro for commands declaration so it can be reused * added open read support * fix format * generic scan of search paths on update commands * format fix * change redismodule-rs dep * update crago toml * move replicate verbatim and notify to be part of the WriteHolder trait * better code reuse * review changes * format changes * proper error on arrpop * test error on arrtrim * move version to redis_json_module_create macro as input * review fixes * fix llapi * apply more changes from master * fmt fixes * fix readies submodule * performance optimization * fmt fixes * small more performance fixes * update jsonpath library * format fixes * update jsonpath library * small fixes * use items instead of keys where possible * fmt fixes * use values iterator instead of get_index_where possible * small performance improvements * small performance improvement * fmt fixes * review fixes * review fixes * fmt fixes * small review fixes Co-authored-by: filipe oliveira <filipecosta.90@gmail.com>
Avoid path clone when not needed
* change llapi to support multiple jsonpath results * format fixes * some more api fixes * review fixes * review fixes * warning fix * review fixes * review fixes
* optimize set root by caching key value * fix format * change pointer to referece * format fixes * review fixes * not using unsafe * review fixes * review fixes
* avoid new String on optional format args
* Update to args:vec<RedisString> * set redimodule-rs 0.20
…also on hdt (#421) * change llapi to be declare on the initialize macro so it can be used also on hdt * format fixes
* move from next_string to next_str * replace next_arg with next
* avoid json clone * avoid clone on arr_insert too
* switch to slice tokenizer json path impl * fmt fixes * change cargo.toml * update cargo.toml * Update src/commands.rs Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> * Update src/redisjson.rs Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com> Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>
…duration (#443) Co-authored-by: Guy Korland <gkorland@gmail.com>
* WIP Add Support for RDB Short Read * WIP Add Support for RDB Short Read (not using macros yet) * WIP allow rdb_load to short read * Add minimal version check for short read * Fixes per Guy's code review * Update .lock to use the last commit of redismodule-rs branch * Module should perform check_minimal_version_for_short_read on its own * Avoid check_minimal_version_for_short_read (there's no aux data) * WIP Add short read test * WIP move to latest redismodule-rs in omer-short-read branch * Handle decoding/encoding in redis connection and mock * Fixes per code review by Gavrie * Deploy ReJSON to S3 * Update readies submodule * Debug: push branch artifacts to S3 * Debug: build platforms * Debug: build platforms (2) * Debug: build platforms (3) * Use latest redismodule-rs in corresponding branch * Fixed per code review by Meir Use Context api set_module_options Use and log the random seed * Minor update to test * Remove aux_load * Update .lock to last commit of corresponding redismodule-rs branch * Bump version of dep redismodule to 0.23.0 and rollback temp CI changes Co-authored-by: Guy Korland <gkorland@gmail.com> Co-authored-by: rafie <rafi@redislabs.com>
* Initial RedisJSON commands.json file * Explain complexity
* Create freebsd.yml
* count cleared results Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>
gkorland
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.