Small int cache like CPython #1502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vm/src/pyobject.rs
Outdated
| pub fn new_int<T: Into<BigInt>>(&self, i: T) -> PyObjectRef { | ||
| let i = i.into(); |
There was a problem hiding this comment.
I was thinking that instead of immediately converting it, T could be Into<BigInt> + PartialOrd<i32>, to save on the overhead of allocation for a BigInt.
There was a problem hiding this comment.
Because PartialOrd<i32> is not implemented for unsigned ints, this way will be tricky
There was a problem hiding this comment.
Maybe T could be ToPrimitive?
There was a problem hiding this comment.
This is great idea. I was struggling with TryInto and TryFrom but ToPrimitive is a lot easier to do this. Thanks!
5c07f6d to
dcd1f31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.