Add str.format_map method #1639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
approved these changes
Dec 23, 2019
vm/src/obj/objstr.rs
Outdated
| return Err( | ||
| vm.new_value_error("Format string contains positional fields".to_string()) | ||
| ); | ||
| } |
There was a problem hiding this comment.
You can merge this match arm and the previous one by using the | character: FormatPart::AutoSpec(_) | FormatPart::IndexSpec (_, _) => { ... }
tests/snippets/builtin_format_map.py
Outdated
|
|
||
|
|
||
| def test_format_map(): | ||
| # The following tests were performed in Python 3.7.5: |
There was a problem hiding this comment.
Could you move these tests to tests/snippets/strings.py? And you don't need the separate test function; our tests right now are a lot less structured than most Python tests 😁
1239f24 to
325fb4c
Compare
|
Thanks again for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #190