Implement P3.9 style dict union (PEP584) #1902
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…handling of quotes is too simple
…ils with defined skpping methods
… type. So far it was a key error now it is a type error.
youknowone
requested changes
May 7, 2020
|
Further reviews/development can be directed to #1911, I believe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the dict union as defined in PEP 854 in RustPython and tests it. Compability tests with Cpython are skipped when tested with Python 3.8 or below (due to abvious reason - Githib doesnt support python 3.9 so far, changing ci configuration failed).
Now it is possible to write things like: