Skip to content

Implement P3.9 style dict union (PEP584) #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 9, 2020

Conversation

TheAnyKey
Copy link
Contributor

This PR implements the dict union as defined in PEP 854 in RustPython and tests it. Compability tests with Cpython are skipped when tested with Python 3.8 or below (due to abvious reason - Githib doesnt support python 3.9 so far, changing ci configuration failed).

Now it is possible to write things like:

        a = {1:2, 2:3}
        b = {3:4, 5:6}
        c=a|b
        a|=b

Copy link
Contributor

@palaviv palaviv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work!!!. Thank you for the contribution.

@palaviv palaviv merged commit ebf6b51 into RustPython:master May 9, 2020
@TheAnyKey TheAnyKey deleted the TheAnyKey/p39_dict_union_pr branch May 10, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants