Fix the deploy condition for missing spaces around equals sign #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -101,7 +101,7 @@ deploy: | |||
| keep-history: true | |||
| on: | |||
| branch: release | |||
| condition: $DEPLOY_DOC=true | |||
| condition: $DEPLOY_DOC = true | |||
There was a problem hiding this comment.
Should it not be DEPLOY_DOC=true? Without the dollar symbol?
There was a problem hiding this comment.
on in the deployment section seems to be different from the if elsewhere. Here is the quote form the doc:
condition: deploy when a single bash condition evaluates to true. This must be a string value, and is equivalent to if [[ <condition> ]]; then <deploy>; fi. For example, $CC = gcc.
Here is a working build: https://travis-ci.org/RustPython/RustPython/builds/478843944 . The deployment steps failed because I set a bad token to avoid actually deploying. But the deployment step seems to kick-off correctly.
There was a problem hiding this comment.
Wow, this is pretty crappy, but good research!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was stupid to forgot to add spaces around the equals signs in the previous PR #250 .
Clearly if you do
$FOO=true, it is always evaluated as true in bash'sif [[ ... ]]condition. (Reference)I tested in a branch and now it seems to skip the deployment step properly: https://travis-ci.org/RustPython/RustPython/builds/478033185