Skip to content

Add atanh and atan to cmath #3175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Conversation

lijm1358
Copy link
Contributor

This implement atan and atanh in #3039

Before

>>>>> import cmath
>>>>> cmath.atan(1)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'cmath' has no attribute 'atan'
>>>>> cmath.atanh(1)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'cmath' has no attribute 'atanh'

After

>>>>> import cmath
>>>>> cmath.atan(2)
(1.1071487177940904+0j)
>>>>> cmath.atanh(2)
(0.5493061443340549-1.5707963267948966j)

Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! The patch looks good, but it had conflict due to previous merge. Could you rebase this patch?

@lijm1358
Copy link
Contributor Author

@youknowone Finished rebase😊

@youknowone youknowone merged commit b4a6b1e into RustPython:main Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants