use PyIterReturn for gen internal #3183
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e39271 to
f2f95fd
Compare
DimitrisJim
reviewed
Oct 1, 2021
vm/src/coroutine.rs
Outdated
| } | ||
| } | ||
| } | ||
|
|
||
| #[derive(Debug)] | ||
| pub struct Coro { | ||
| frame: FrameRef, | ||
| pub closed: AtomicCell<bool>, | ||
| pub closed: AtomicCell<bool>, // redudant? |
There was a problem hiding this comment.
If frame was made into an option closed could be removed. That's closer to what CPython does.
There was a problem hiding this comment.
I replaced this comment to link to this comment
|
merged #3185 first so other PRs that might come before this is merged won't get stuck on the failing tests. |
f2f95fd to
e547ca3
Compare
e547ca3 to
3eec37b
Compare
3eec37b to
198a2b3
Compare
|
merged by #3202 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.