Added inverse sine and inverse cosine #3198
Conversation
Signed-off-by: snowapril <sinjihng@gmail.com>
Signed-off-by: snowapril <sinjihng@gmail.com>
Signed-off-by: snowapril <sinjihng@gmail.com>
Signed-off-by: snowapril <sinjihng@gmail.com>
Signed-off-by: snowapril <sinjihng@gmail.com>
stdlib/src/cmath.rs
Outdated
| @@ -78,12 +78,23 @@ mod cmath { | |||
| z.to_complex().sin() | |||
| } | |||
|
|
|||
| /// Return the inverse sine of z | |||
There was a problem hiding this comment.
We don't write our original document here. They are expected to be same as CPython.
Actually we don't need document anyomre. #3101 is recently brought up, so you simply can remove comment here to let it follow the default CPython document database.
There was a problem hiding this comment.
Ok. Should i also remove all the comments which were there previously?
clean up py* attributes names
Add missing `repr` for `mappingproxy`
Fix pystruct incompatibility and add `test_buffer.py` from cpython 3.8
|
I think updating the tests may be worthwhile, you could refer to #3200 if you want to |
|
ok! |
|
i have made the changes in test_cmath.py |
|
You'll need to rebase, there were recent changes in # TODO: RUSTPYTHON
# This line currently fails for acos and asin
# cmath.asin(0.2) should produce a real number,
# but imaginary part is 1.1102230246251565e-16 for both.
if fn != "asin" and fn != "acos":
self.assertEqual(0., z.imag)@youknowone I'll handle this PR and then open another one to bring |
Remove impl TryFromObject for SequenceIndex
Use PyInt::try_to_primitive.
|
Great! You'll just need to rebase now, there's still conflicts present. |
Modify range in sre.rs
Fix array repr
clean up derive
Remove not very useful iterator utilty functions
|
rebase is required, not merge(or pull) check this article: https://www.atlassian.com/git/tutorials/merging-vs-rebasing |
This reverts commit f8618ba.
|
I am very sorry for making this mess, how can i fix this? Sorry for the trouble 😔 |
|
I would do squash(using rebase -i to last common commit) everything to a single commit and cherry-pick it onto the upstream main. |
|
Sorry for troubling you, but I couldnt figure out how to fix this 😔 |
No description provided.