Skip to content

add fn Binascii rlecode_hqx rledecode_hqx #3809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 23, 2022
Merged

add fn Binascii rlecode_hqx rledecode_hqx #3809

merged 8 commits into from
Jun 23, 2022

Conversation

yangbeom
Copy link
Contributor

add function binascii.rlecode_hqx and binascii.rledecode_hqx with reference to cpython (binascii_rlecode_hqx_impl, binascii_rledecode_hqx_impl in binascii.c)
remove unittest.expectedFailure decorator test_rle in test_binascii.py

TestResult

/Users/yangbeom/github/RustPython ❯❯❯ cargo run --release Lib/test/test_binascii.py

Finished release [optimized] target(s) in 0.28s
 Running 'target/release/rustpython Lib/test/test_binascii.py'

.xx...x.xxxxxx.xxx.xx...x.xxxxxx.xxx.xx...x.xxxxxx.xxx.xx...x.xxxxxx.xxx

Ran 72 tests in 0.015s

OK (expected failures=48)

Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I left a few comments, mostly about style.

@youknowone
Copy link
Member

if you are planning to work more on this module, please be aware a2b_hqx is deprecated.

yangbeom and others added 4 commits June 23, 2022 21:33
Co-authored-by: Jeong YunWon <69878+youknowone@users.noreply.github.com>
Co-authored-by: Jeong YunWon <69878+youknowone@users.noreply.github.com>
@yangbeom
Copy link
Contributor Author

yangbeom commented Jun 23, 2022

if you are planning to work more on this module, please be aware a2b_hqx is deprecated.

Thanks, I'll try to find other

Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you for contributing!

@youknowone youknowone merged commit 00cb5ca into RustPython:main Jun 23, 2022
chang-57 pushed a commit to chang-57/RustPython that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants