-
Notifications
You must be signed in to change notification settings - Fork 1.3k
add fn Binascii rlecode_hqx rledecode_hqx #3809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! I left a few comments, mostly about style.
if you are planning to work more on this module, please be aware |
Co-authored-by: Jeong YunWon <69878+youknowone@users.noreply.github.com>
Co-authored-by: Jeong YunWon <69878+youknowone@users.noreply.github.com>
Thanks, I'll try to find other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thank you for contributing!
add function binascii.rlecode_hqx and binascii.rledecode_hqx with reference to cpython (binascii_rlecode_hqx_impl, binascii_rledecode_hqx_impl in binascii.c)
remove unittest.expectedFailure decorator test_rle in test_binascii.py
TestResult
/Users/yangbeom/github/RustPython ❯❯❯ cargo run --release Lib/test/test_binascii.py
.xx...x.xxxxxx.xxx.xx...x.xxxxxx.xxx.xx...x.xxxxxx.xxx.xx...x.xxxxxx.xxx
Ran 72 tests in 0.015s
OK (expected failures=48)