Skip to content

A follow-up for #4324 #4325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2022
Merged

A follow-up for #4324 #4325

merged 1 commit into from
Dec 10, 2022

Conversation

harupy
Copy link
Contributor

@harupy harupy commented Dec 10, 2022 •
edited
Loading

A follow-up for #4324. Refactors the code a bit.

@harupy
Copy link
Contributor Author

harupy commented Dec 10, 2022

@DimitrisJim Would you mind taking a look?

DimitrisJim
DimitrisJim approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I guess it doesn't make much sense to yank the node just to put back in a Expr::new

@DimitrisJim DimitrisJim merged commit 2edd0d2 into RustPython:main Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harupy @DimitrisJim