Another temporary fix for #4566 #4582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
approved these changes
Feb 26, 2023
|
Oh, no. The UnicodeData.txt does include aliases but not abbrs. |
|
ah, that's true, I hadn't noticed that either tbh since I just looked into NameAliases.txt (and it's actually annoying unfortunately since you now need to handle both files.) |
034d504 to
fbf400e
Compare
|
does your branch of unicode_names2 currently handle the abbreviations? If so, lets merge it. |
fbf400e to
c0f5266
Compare
|
Yes, finally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also #4572
we can temporarily go with this because unicode_names2 will work with this interface in future.
closes #4566