Skip to content

resolve unittest error in test_sort.py #4756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2023
Merged

resolve unittest error in test_sort.py #4756

merged 1 commit into from
Mar 25, 2023

Conversation

JaeyoungAhn
Copy link
Contributor

@JaeyoungAhn JaeyoungAhn commented Mar 25, 2023 •
edited
Loading

modified richcompare fn in iter.rs to #4564 resolve unittest error in test_sort.py

removed TODO mark in test_sort.py

DimitrisJim
DimitrisJim reviewed Mar 25, 2023
View reviewed changes
@youknowone youknowone added C-bug Something isn't working A-stdlib z-ls-2023 Tag to track Line OSS Sprint 2023 z-ca-2023 Tag to track contrubution-academy 2023 and removed z-ls-2023 Tag to track Line OSS Sprint 2023 labels Mar 25, 2023
youknowone
youknowone approved these changes Mar 25, 2023
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@youknowone youknowone merged commit d5975a4 into RustPython:main Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim left review comments

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
A-stdlib C-bug Something isn't working z-ca-2023 Tag to track contrubution-academy 2023
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JaeyoungAhn @youknowone @DimitrisJim