Skip to content

Support magic methods for in-place operations #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 18, 2019
Merged

Support magic methods for in-place operations #492

merged 6 commits into from
Feb 18, 2019

Conversation

OddCoincidence
Copy link
Contributor

@OddCoincidence OddCoincidence commented Feb 17, 2019 •
edited
Loading

Resolves #449 and #198

@OddCoincidence
Copy link
Contributor Author

OddCoincidence commented Feb 17, 2019 •
edited
Loading

What's the deal with the code coverage check?

profiling: /home/travis/build/RustPython/RustPython/target/debug/deps/rustpython_vm-e0c4f91f893f6a2e.gcda: cannot merge previous GCDA file: mismatched number of counters (8)
profiling: /home/travis/build/RustPython/RustPython/target/debug/deps/rustpython_vm-e0c4f91f893f6a2e.gcda: cannot merge previous GCDA file: corrupt arc tag (0x24544724)
profiling: /home/travis/build/RustPython/RustPython/target/debug/deps/rustpython_vm-e0c4f91f893f6a2e.gcda: cannot merge previous GCDA file: corrupt arc tag (0x00000000)
profiling: /home/travis/build/RustPython/RustPython/target/debug/deps/rustpython_vm-e0c4f91f893f6a2e.gcda: cannot merge previous GCDA file: corrupt arc tag (0x75242454)
profiling: /home/travis/build/RustPython/RustPython/target/debug/deps/rustpython_vm-e0c4f91f893f6a2e.gcda: cannot merge previous GCDA file: corrupt arc tag (0x00000000)
profiling: /home/travis/build/RustPython/RustPython/target/debug/deps/rustpython_vm-e0c4f91f893f6a2e.gcda: cannot merge previous GCDA file: corrupt arc tag (0x314e5a5f)

... a bajillion more

The job exceeded the maximum log length, and has been terminated.

EDIT: Looks like it was leftover gcda files (I guess from travis caching?). Deleting them before the code coverage build seems to fix it.

Q: I get a lot of errors from lcov along the lines of cannot merge previous GCDA file: corrupt [something], what’s wrong?
A: You have ran an executable with branch coverage enabled, then rebuilt it, and ran again, thus attempting to merge the coverage information from two different compilations. Remove the *.gcda files and try again.

https://users.rust-lang.org/t/howto-generating-a-branch-coverage-report/8524

adrian17
adrian17 reviewed Feb 17, 2019
View reviewed changes
@codecov-io
Copy link

codecov-io commented Feb 18, 2019 •
edited
Loading

Codecov Report

Merging #492 into master will decrease coverage by 2.72%.
The diff coverage is 59.4%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
- Coverage   61.27%   58.55%   -2.73%     
==========================================
  Files          67       67              
  Lines       11516    12080     +564     
  Branches     2583     2787     +204     
==========================================
+ Hits         7057     7073      +16     
- Misses       2701     3233     +532     
- Partials     1758     1774      +16
Impacted Files Coverage Δ
vm/src/bytecode.rs 44.13% <0%> (-27.15%) ⬇️
vm/src/compile.rs 61.57% <100%> (-12.76%) ⬇️
vm/src/obj/objlist.rs 37.79% <28.57%> (-13.51%) ⬇️
vm/src/vm.rs 67.95% <60.12%> (-7.12%) ⬇️
vm/src/frame.rs 52.13% <68%> (-18.89%) ⬇️
vm/src/stdlib/string.rs 27.74% <0%> (+1.73%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af9cc0...ddc7da4. Read the comment docs.

@windelbouwman windelbouwman merged commit 70d5cdb into RustPython:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrian17 adrian17 adrian17 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OddCoincidence @codecov-io @adrian17 @windelbouwman