Skip to content

Complement vm logics related with ParamSpec and TypeVarTuple #5505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2025
Merged

Complement vm logics related with ParamSpec and TypeVarTuple #5505

merged 1 commit into from
Feb 10, 2025

Conversation

moreal
Copy link
Contributor

@moreal moreal commented Feb 6, 2025 •
edited
Loading

This pull request complements compiler, vm logics related PEP-0695.

@moreal moreal changed the title Implement vm logics related with ParamSpec and TypeVarTuple Complement vm logics related with ParamSpec and TypeVarTuple Feb 6, 2025
@moreal moreal mentioned this pull request Feb 6, 2025
Closed
@moreal moreal marked this pull request as ready for review February 7, 2025 01:04
youknowone
youknowone reviewed Feb 10, 2025
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!
Is there any related test about this changes in test_typing?

(okay if there is nothing or not the full test is passed yet)

@moreal
Copy link
Contributor Author

moreal commented Feb 10, 2025 •
edited
Loading

@youknowone PEP-0695 is applied since Python 3.12 and current typing module (on main branch) is on Python 3.10.5. So I guess there are no related tests about this pull request.

Also, this pull request is originally part of #5486 but I am separating this commit from the PR for ease of review. There are more works for marking #5486 as ready-to-review 😞

error: Python compile error from Lib/test/test_typing.py: cannot use starred expression here at row 1081 col 25
  --> pylib/src/lib.rs:14:35
   |
14 |     rustpython_derive::py_freeze!(dir = "./Lib", crate_name = "rustpython_compiler_core");
   |                                   ^^^^^^^^^^^^^

error: could not compile `rustpython-pylib` (lib) due to 1 previous error

@moreal moreal requested a review from youknowone February 10, 2025 11:10
youknowone
youknowone approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, got it. Thank you for explanation!

@youknowone youknowone merged commit 465627f into RustPython:main Feb 10, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moreal @youknowone