Skip to content

Update to windows-2025 runner on ci #5571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

coolreader18
Copy link
Member

This comes preinstalled with openssl 3, so we can cut out building openssl ourselves, which takes 5 minutes every CI run.

@coolreader18 coolreader18 force-pushed the ci-windows-2025 branch 2 times, most recently from f70cf66 to 1dc3df4 Compare February 28, 2025 01:48
@arihant2math
Copy link
Collaborator

The issue here is env variables that point to the openssl installation are not set.

Setting all the variables specified in sfackler/rust-openssl#1542 (comment) should resolve this.

@coolreader18 coolreader18 force-pushed the ci-windows-2025 branch 7 times, most recently from c259f8d to 2e9aa8d Compare February 28, 2025 20:41
@coolreader18
Copy link
Member Author

@youknowone you added the win32_xstat impl in #5247 - do you know why the tests fixed by that might be failing now with a windows update? It's not like they would've removed the api-ms-win-core-file-l2-1-4 API set.

@youknowone
Copy link
Member

I am sorry. I code like a monkey with wniapi. I really don't know well about their details.

@bjia56
Copy link

bjia56 commented Mar 7, 2025

I mentioned this link in #5583, but openssl prebuilts are also available from the cpython project here https://github.com/python/cpython-bin-deps/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants