Skip to content

Scope globals locals #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 10, 2019
Merged

Scope globals locals #637

merged 7 commits into from
Mar 10, 2019

Conversation

cthulahoops
Copy link
Collaborator

Restructure Scope (again) so I can separate globals and locals properly. Scope now has a narrow interface so we can make further changes more easily.

I can now enable the broken tests in test_exec.

There's also the beginnings of a new AttributeProtocol that I plan on merging with the existing one.

@cthulahoops cthulahoops force-pushed the scope_globals_locals branch from 1d8eff1 to 8e4ccf9 Compare March 10, 2019 12:47
@cthulahoops cthulahoops force-pushed the scope_globals_locals branch from d6cd617 to 4a82c8f Compare March 10, 2019 12:51
@codecov-io
Copy link

codecov-io commented Mar 10, 2019

Codecov Report

Merging #637 into master will increase coverage by 0.13%.
The diff coverage is 54.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
+ Coverage   40.86%   40.99%   +0.13%     
==========================================
  Files          77       77              
  Lines       17468    17554      +86     
  Branches     4510     4519       +9     
==========================================
+ Hits         7139     7197      +58     
- Misses       8433     8451      +18     
- Partials     1896     1906      +10
Impacted Files Coverage Δ
vm/src/macros.rs 14.28% <ø> (ø) ⬆️
src/main.rs 15% <0%> (-0.86%) ⬇️
wasm/lib/src/vm_class.rs 0% <0%> (ø) ⬆️
vm/src/obj/objframe.rs 30.23% <100%> (ø) ⬆️
vm/src/eval.rs 41.37% <100%> (ø) ⬆️
vm/src/obj/objdict.rs 43.88% <50%> (-0.84%) ⬇️
vm/src/obj/objfunction.rs 35.86% <50%> (+4.13%) ⬆️
vm/src/import.rs 43.2% <50%> (-2.85%) ⬇️
vm/src/obj/objmodule.rs 81.25% <50%> (ø) ⬆️
vm/src/frame.rs 47.25% <53%> (+0.73%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e5b76c...3fbf627. Read the comment docs.

@cthulahoops
Copy link
Collaborator Author

@windelbouwman Happy with this version?

@windelbouwman
Copy link
Contributor

Yes, I think we converged to something good.

@windelbouwman windelbouwman merged commit e8ec497 into master Mar 10, 2019
@cthulahoops cthulahoops deleted the scope_globals_locals branch April 9, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants