Skip to content

[BUG] UL list dots rendered on the left for rtl text #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dzsonni opened this issue May 9, 2023 · 2 comments · Fixed by #1270
Closed

[BUG] UL list dots rendered on the left for rtl text #1257

dzsonni opened this issue May 9, 2023 · 2 comments · Fixed by #1270
Assignees
@Sub6Resources
Labels
bug Something isn't working lists Issues with <ol>, <ul>, and <li> rtl-text Issues with text rendered in rtl mode
Milestone
3.0.0

Comments

@dzsonni
Copy link

dzsonni commented May 9, 2023 •
edited by Sub6Resources
Loading

Describe the bug:
The list indicator is drawn on the left of UL(and possibly OL).

HTML to reproduce the issue:

<ul dir="rtl">
<li>عند تلقي المشورة أو الخضوع لفحص جسدي، يحق للمستفيد/للمستفيدة من الخدمات أن يعرف/تعرف دور كل فرد في الغرفة (مثل الأفراد الذين يخضعون للتدريب، والمشرفين، والمدربين، والباحثين، إلخ). إذا كان وجود أفراد يخضعون للتدريب ضروريًا، ينبغي الحصول على إذن مسبق من المستفيد/المستفيدة من الخدمات.</li>
<li>للمستفيد(ة) من الخدمات الحق في معرفة نوع الفحص الجسدي الذي سيتم إجراؤه مسبقًا. يحق للمستفيد(ة) من الخدمات أيضًا رفض أي فحص إذا لم يشعر/تشعر بالراحة تجاهه أو أن يطلب/تطلب قيام مقدم رعاية صحية آخر بإجراء هذا الفحص.</li>
<li>المناقشات المتعلقة بالحالة التي تُعقد بحضور المستفيد(ة) (لا سيما في مرافق التدريب) ينبغي أن يشارك/تشارك فيها المستفيد(ة) ويقر/تقر بها.</li>
</ul>

Html widget configuration:
Default configuration. From latest master branch.

Expected behavior:
The indicators should be on the right, or the beginning of the content.

Screenshots:
image

Device details and Flutter/Dart/flutter_html versions:
Latest master. flutter_html-c75e0dfb1be6cb79748f719487043d12bc330c60

Stacktrace/Logcat

Additional info:

A picture of a cute animal (not mandatory but encouraged)

image
@dzsonni dzsonni added the bug Something isn't working label May 9, 2023
@Sub6Resources Sub6Resources added rtl-text Issues with text rendered in rtl mode lists Issues with <ol>, <ul>, and <li> in-triage Issue's that I've seen but haven't had a chance to thoroughly review and/or categorize and removed in-triage Issue's that I've seen but haven't had a chance to thoroughly review and/or categorize labels May 10, 2023
@Sub6Resources Sub6Resources mentioned this issue May 16, 2023
Merged
@Sub6Resources
Copy link
Owner

Opened a PR with a fix: #1270

@dzsonni
Copy link
Author

dzsonni commented May 17, 2023

@Sub6Resources Checked the PR branch, fixes the issue. Thank you. This can be closed after it is merged.

@Sub6Resources Sub6Resources added this to the 3.0.0 milestone May 17, 2023
@Sub6Resources Sub6Resources self-assigned this May 18, 2023
@Sub6Resources Sub6Resources moved this to Done in flutter_html Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sub6Resources Sub6Resources

Labels
bug Something isn't working lists Issues with <ol>, <ul>, and <li> rtl-text Issues with text rendered in rtl mode
Projects
flutter_html
Status: Done
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

feat: Update CssBoxWidget to handle rtl marker boxes Sub6Resources/flutter_html
2 participants
@dzsonni @Sub6Resources