feat: Update CssBoxWidget to handle rtl marker boxes #1270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1270 +/- ##
==========================================
+ Coverage 60.02% 64.11% +4.09%
==========================================
Files 37 38 +1
Lines 2699 2979 +280
==========================================
+ Hits 1620 1910 +290
+ Misses 1079 1069 -10
☔ View full report in Codecov by Sentry. |
… Update CssBoxWidget to handle rtl marker boxes
18db545 to
d9fe7d5
Compare
Luca-CZ
added a commit
to CZ-App/flutter_html_lite
that referenced
this pull request
Nov 11, 2024
…rsion - **FIX**: start list items on a new line ([Sub6Resources#1281](Sub6Resources#1281)). ([496d1aa](Sub6Resources@496d1aa)) - **FIX**: Add "display: Display.block" to table ([Sub6Resources#1278](Sub6Resources#1278)). ([6350f02](Sub6Resources@6350f02)) - **FIX**: improve API for ExtensionContext and export marker.dart ([Sub6Resources#1273](Sub6Resources#1273)). ([27e33a9](Sub6Resources@27e33a9)) - **FIX**: Cleaned up whitespace processing and added whitespace tests ([Sub6Resources#1267](Sub6Resources#1267)). ([cc00406](Sub6Resources@cc00406)) - **FIX**: a tag should not style as link if href is not provided ([Sub6Resources#1265](Sub6Resources#1265)). ([d7247cb](Sub6Resources@d7247cb)) - **FEAT**: Update CssBoxWidget to handle rtl marker boxes ([Sub6Resources#1270](Sub6Resources#1270)). ([d709199](Sub6Resources@d709199)) - **FEAT**: support vertical-align in inline styles ([Sub6Resources#1266](Sub6Resources#1266)). ([fe896de](Sub6Resources@fe896de)) - **FEAT**: Add WrapperExtension helper ([Sub6Resources#1264](Sub6Resources#1264)). ([2ffa1dd](Sub6Resources@2ffa1dd))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involved adding more options to the
Marginsclass, as well as refactoring thepaddingoption to take a newHtmlPaddingsobject.Fixes #1257