Skip to content

Conversation

arjanmels
Copy link
Contributor

Added "display: Display.block" to table to properly handle a.o. vertical margins.

@arjanmels arjanmels force-pushed the AM_fix_table_display branch from eaa8a4a to bd04e7d Compare May 20, 2023 11:57
Copy link
Owner

@Sub6Resources Sub6Resources left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Eventually we'll consider adding a Display.table option. But that's out of the question right now with our table extension being so separate from the standard elements (and bug-ridden at the moment).

@Sub6Resources Sub6Resources merged commit 6350f02 into Sub6Resources:master May 23, 2023
@soktherat
Copy link

It causes exceptions in large table inside SingleChildScrollView.

@Sub6Resources
Copy link
Owner

@soktherat Can you open a new issue with a description of the error you are seeing and some code to reproduce?

Luca-CZ added a commit to CZ-App/flutter_html_lite that referenced this pull request Nov 11, 2024
…rsion

 - **FIX**: start list items on a new line ([Sub6Resources#1281](Sub6Resources#1281)). ([496d1aa](Sub6Resources@496d1aa))
 - **FIX**: Add "display: Display.block" to table ([Sub6Resources#1278](Sub6Resources#1278)). ([6350f02](Sub6Resources@6350f02))
 - **FIX**: improve API for ExtensionContext and export marker.dart ([Sub6Resources#1273](Sub6Resources#1273)). ([27e33a9](Sub6Resources@27e33a9))
 - **FIX**: Cleaned up whitespace processing and added whitespace tests ([Sub6Resources#1267](Sub6Resources#1267)). ([cc00406](Sub6Resources@cc00406))
 - **FIX**: a tag should not style as link if href is not provided ([Sub6Resources#1265](Sub6Resources#1265)). ([d7247cb](Sub6Resources@d7247cb))
 - **FEAT**: Update CssBoxWidget to handle rtl marker boxes ([Sub6Resources#1270](Sub6Resources#1270)). ([d709199](Sub6Resources@d709199))
 - **FEAT**: support vertical-align in inline styles ([Sub6Resources#1266](Sub6Resources#1266)). ([fe896de](Sub6Resources@fe896de))
 - **FEAT**: Add WrapperExtension helper ([Sub6Resources#1264](Sub6Resources#1264)). ([2ffa1dd](Sub6Resources@2ffa1dd))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants