-
-
Notifications
You must be signed in to change notification settings - Fork 905
[Proposal] Modularization #661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… in core, & update example
…tional function parameter
…into feature/modularization � Conflicts: � README.md � example/lib/main.dart
…into feature/modularization � Conflicts: � lib/flutter_html.dart � lib/html_parser.dart � lib/src/html_elements.dart
@erickok this PR can be reviewed even though 3/6 list items are complete (I can't do the other three, they need to be done after a possible merge of This is a proposal after all so if you have different ideas or would like to make your own PR then this can wait. |
…into feature/modularization � Conflicts: � README.md � lib/flutter_html.dart � lib/html_parser.dart � lib/src/replaced_element.dart
…eotia/flutter_html into feature/modularization � Conflicts: � README.md � example/lib/main.dart � lib/custom_render.dart � lib/html_parser.dart
Seems like this will require quite the merge, I will try to get to this today or tomorrow. |
I'm afraid so. It's my fault for having this hang around so long. But we are finally here. |
# Conflicts: # README.md # example/lib/main.dart # lib/flutter_html.dart # lib/html_parser.dart # lib/image_render.dart # lib/src/html_elements.dart # lib/src/layout_element.dart # lib/src/replaced_element.dart # lib/src/utils.dart # lib/src/widgets/iframe_mobile.dart # lib/src/widgets/iframe_unsupported.dart # lib/src/widgets/iframe_web.dart # pubspec.yaml # test/html_parser_test.dart
…into feature/modularization � Conflicts: � lib/flutter_html.dart � lib/html_parser.dart � lib/src/replaced_element.dart � lib/src/utils.dart
@erickok this is ready to go now. A 3.0.0 migration guide is also created in the wiki. |
Thanks so much! I'm going to test tomorrow and merge if all is working. |
Sounds good. Just before merge we would need to create that 3.0.0 alpha release, and update the modularization packages to remove the path dependencies and instead depend on the 3.0.0-alpha flutter_html |
Here is my PR for modularization, largely based off the written proposal in #645. Includes all changes from #632, but that should be merged first, and a release should be created with those changes.
Fixes #323, fixes #442.
Changes
flutter_html_all
- convenience package that exports all other packagesflutter_html_audio
- provides audio tag, useschewie_audio
andvideo_player
flutter_html_iframe
- provides iframe tag, useswebview_flutter
flutter_html_math
- provides math tag, usesflutter_math_fork
flutter_html_svg
- provides svg tag & svg image, usesflutter_svg
flutter_html_table
- provides table tag, usesflutter_layout_grid
flutter_html_video
- provides video tag, useschewie
andvideo_player
html
,csslib
,collection
🎉customImageRender
and merged withcustomRender
since it basically provides the same effectnavigationDelegateForIframe
, it can now be set via a parameter in theiframeRender()
CustomRender
onMathError
, it can now be set via a parameter in themathRender()
CustomRender
Pending (complete in order)
CustomRender
s into functions to keep things consistent with default renders in the "core" libraryflutter_html
withcustomRender
changesExample
Let's say the user wants to have the full-fat
flutter_html
experience with support for all the tags. With this PR, it would look like this:pubspec.yaml
.dart
Debates
customImageRender
? I made those changes in a separate commit to make it easily revertable if we decide this. Personally I see no reason for it now, but I could be swayed against this change.Map<CustomRenderMatcher, CustomRender>
in theflutter_html_all
package? Rather than the user having to do the above, they could simply docustomRenders: allRenders
or something like that.