fix: aspect ratio should never be NaN. #769
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickok
approved these changes
Jul 23, 2021
| final heightString = attributes["height"]; | ||
| final widthString = attributes["width"]; | ||
| if (heightString != null && widthString != null) { | ||
| final height = double.tryParse(heightString); | ||
| final width = double.tryParse(widthString); | ||
| return height == null || width == null ? calculated.data!.aspectRatio : width / height; |
There was a problem hiding this comment.
I think you solution is okay but would it have been enough to just check that height is not 0 and return 1 in that case?
|
#1222 provides a more clean solution. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
attributesMap, when width & height both are "0", the_aspectRatiofunction was returningNaNinstead some valid ratio.