Skip to content

Conversation

kolosovpetro
Copy link
Contributor

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md

@kolosovpetro kolosovpetro requested a review from siriak as a code owner January 7, 2022 22:40
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #280 (447dbf1) into master (c95d8aa) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
+ Coverage   94.97%   95.11%   +0.13%     
==========================================
  Files         158      159       +1     
  Lines        7581     7670      +89     
==========================================
+ Hits         7200     7295      +95     
+ Misses        381      375       -6     
Impacted Files Coverage Δ
...hms/Problems/CoinChange/DynamicCoinChangeSolver.cs 100.00% <100.00%> (ø)
Algorithms/Numeric/MillerRabinPrimalityChecker.cs 100.00% <0.00%> (+18.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c95d8aa...447dbf1. Read the comment docs.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, please add some comments explaining what methods do

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only minor suggestions

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@siriak siriak merged commit c4a2639 into TheAlgorithms:master Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants